rjancewicz / python-kadmin

Python module for kerberos admin (kadm5)
MIT License
35 stars 42 forks source link

create_principal extension + don't leak memory when raising errors #21

Closed denys-duchier closed 9 years ago

denys-duchier commented 10 years ago

Hi, I started using your code to script updates to our kerberos server and I find it very convenient. For create_principal, I needed to pass a db option to say where to store it in our LDAP database (I am using a "x" keyword argument for that purpose, like the -x option in the kadmin tool).

As I was looking over the code, it seemed to me that it would often leak memory when using PyKAdmin_RETURN_ERROR. So I tried to fix that too.