rjancewicz / python-kadmin

Python module for kerberos admin (kadm5)
MIT License
35 stars 40 forks source link

implementing the delprinc method on PyKAdminPrincipalObjects #36

Closed liammonahan closed 9 years ago

liammonahan commented 9 years ago

Hi,

I've implemented a delete() method on principal objects themselves as opposed to just on PyKadminObject, but I had a question about the implementation first. After calling kadm5_delete_principal(...), should we call the destructor--PyKAdminPrincipalObject_destroy(self)--proactively or wait for that to get done automatically when the object refcount goes to zero?

Let me know if this doesn't make any sense and I'll put in the MR for you to see exactly what I'm doing.

Thanks, Liam