search

rjanja / desktop-capture

Screenshot and screencasting tools for Cinnamon.
40 stars 11 forks source link

Port settings to Cinnamon 1.8 settings API #18

Closed jonbrett closed 11 years ago

jonbrett commented 11 years ago

As title it would be nice if the applet settings used the new(ish) Cinnamon 1.8 settings API, since it would

  1. Make the settings form more consistent with the rest of the desktop
  2. Allow settings to be preserved across applet updates
  3. Reduce the code size (no need to include code to draw settings form etc).

A good starting point for understanding the Cinnamon settings API

rjanja commented 11 years ago

I have a new-settings branch that uses the settings API to some degree. 1) and 3) aren't real considerations of mine, as any performance impact from this applet is likely to come from elsewhere in the program. I think Settings is available by now on most if not all Cinnamon installations. I'll take a look at updating this.

jonbrett commented 11 years ago

@ranja Sorry, I didn't notice that branch! Well at least you've got a matching issue now...

By the way my point in 3.) was not related to performance but to maintainability. Although seeing that you've already started on the porting work I guess you don't need me to provide reasons to convince you :)

rjanja commented 11 years ago

Thanks @jonbrett. That branch is a bit dated as the settings API work was still in progress at the time, but the preservation of settings (2) is the biggest gain here. I agree about the maintainability aspect going forward. The settings API discussion went on for a year or more and it wasn't very clear what format it would end up in so I wasn't apt to abandon my own settings app just yet :).

I'll leave this issue open pending integration of settings API in master branch/spices release. Cheers

rjanja commented 11 years ago

Settings API integrated as of 0cd64d0ded0243aff93f12336897b827b889c933