search

rjanja / desktop-capture

Screenshot and screencasting tools for Cinnamon.
40 stars 11 forks source link

notification-with-image css selector not used #51

Closed zagortenay333 closed 7 years ago

zagortenay333 commented 7 years ago

Isn't this code supposed to add that selector: https://github.com/rjanja/desktop-capture/blob/4cde330caa5bf2b15adc8c408bab9375ea8cc383/capture%40rjanja/applet.js#L163-L165

rjanja commented 7 years ago

Yes. What theme are you testing?

zagortenay333 commented 7 years ago

No need to test it with a theme, just use looking glass. Also most themes don't make a distinction there to be able to see it. https://github.com/zagortenay333/ciliora-secunda-cinnamon

rjanja commented 7 years ago

Thanks @zagortenay333, I've corrected the code that should have been adding the CSS class.

Please note that this fix won't appear until release of 1.09, which has to wait until the Cinnamon Spices site is back up and available to applet authors. For now I can't upload any new versions.

Here is what this style looks like on stock Cinnamon theme. The 159px is the default from the cinnamon.css while the green background is something I temporarily added (but not committed).

#notification.notification-with-image {
   min-height: 159px;
   background-color: green;
}

screenshot-area-2016-12-31-170924

zagortenay333 commented 7 years ago

Nice, but how come you can't upload to spices? Didn't you update it just 3 days ago?

rjanja commented 7 years ago

Yes. The Cinnamon Spices are themselves being migrated to Github for the purpose of undergoing code reviews before publishing. No applets can currently be updated, unfortunately. If you'd like I can drop a zip file somewhere for you.

zagortenay333 commented 7 years ago

Oh.

Nah, I already installed. It works as it should now.