search

rjanja / desktop-capture

Screenshot and screencasting tools for Cinnamon.
40 stars 11 forks source link

Fix some JS warnings and imgur wizard for cinnamon 3.4 #76

Closed NikoKrause closed 7 years ago

NikoKrause commented 7 years ago

The first commit removes some trailing spaces (I use atom, which removes them automatically. To make review easier I put this into a separate commit).

The second commit fixes some JS warnings. Closes #74

The third commit fixes #75 In Cinnamon 3.4 the CJS Javascript interpreter was rebased and now runs on mozjs 38. It causes js to crash, if a variable is declared twice within the same scope. Removing those duplicate let declarations and the wizard starts as expected.

And the res variable was undeclared.

rjanja commented 7 years ago

Thanks @NikoKrause! Sorry it took me so long to take a look at this PR. Cheers!