ability replace https by http

rjanot / YuccaPrerenderBundle

Symfony2 Bundle to use prerender.io

MIT License

56 stars 15 forks source link

ability replace https by http #18

Closed tomfun closed 9 years ago

tomfun commented 9 years ago

in some cases of production environment, is needed replace scheme. in my case http -> https. in this pull request, i added configuration option, which can be placed in parameters.yml for a server. by default configuration, this feature does nothing. also don't forget to change name.

rjanot commented 9 years ago

Hi tomfun !

Thanks for the PR! I really appreciate ! But before merging, I'll ask you to do some fixes to your code:

Tests are no more passing since you change the constructor argument list order. Please, add the new argument at the end, or by a setter, to avoid BC Break (even if the bundle is not as used as symfony :) )
In the composer.json, please don't change the name
In the Configuration default, please don't change the server default.

With that Done, I'll be happy to merge your work