search

rjarry / grout

grout # a graph router based on DPDK
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Devtools #33

Closed rjarry closed 2 weeks ago

rjarry commented 2 weeks ago

Great, somehow this check works for me:

rjarry@ringo:~/rh/grout devtools$ make check-patches REVISION_RANGE=df3dd5d7717bbe20bb2c988a42316716c7235c7e..1f167fcd8bb4db9c225fc1b6d8e292fbe652b4d4
ok    [PATCH 1/3] 'devtools: add check-patches script'
ok    [PATCH 2/3] 'devtools: add check-whitespace script'
ok    [PATCH 3/3] 'devtools: add commit-msg script'
3/3 valid patches

But fails on github env:

github:~$ make check-patches REVISION_RANGE=df3dd5d7717bbe20bb2c988a42316716c7235c7e..1f167fcd8bb4db9c225fc1b6d8e292fbe652b4d4
fatal: Invalid revision range df3dd5d7717bbe20bb2c988a42316716c7235c7e..1f167fcd8bb4db9c225fc1b6d8e292fbe652b4d4
david-marchand commented 2 weeks ago

Just an idea.. is github using shallow clone?

rjarry commented 2 weeks ago

Yes, that was it. I had accidentally removed fetch-depth: 0 from the checkout options...