rjbain / dgreat

MIT License
3 stars 0 forks source link

Image Carousel/Slider #134

Open drmyers1 opened 6 years ago

drmyers1 commented 6 years ago

@rjbain we got feedback from @tomkhenke and he noted that the paragraph image carousel/slider does not seem to work. @tomkhenke said there is a bootstrap version that seems more stable. Is it possible to replace the paragraph sider and use the bootstrap? @tomkhenke let me know if I missed anything. @rjbain Can you provide your thoughts on this?

rjbain commented 6 years ago

@drmyers1 are there any examples on the site that I can look at? The bootstrap paragraphs widget uses bootstrap, so I'm not sure which bootstrap slider is the one that's more stable.

sozguzer commented 6 years ago

Hi Rob, Michael used the code from the bootstrap document (https://getbootstrap.com/docs/4.0/components/carousel/) to create calendar and homepage carousels (the one with the captions: <div class="carousel-item"> <img src=" " alt="..."> <div class="carousel-caption d-none d-md-block"> <h5>...</h5> <p>...</p> </div> </div>

That seems to work well. The paragraphs one is missing the previous and next buttons. When I compare the code with the paragraphs' carousel code (http://dev-dgreat.pantheonsite.io/student-health-safety/hps), the classes used are different in paragraphs version and no css is defined for it anywhere.

Previous button from Bootstrap : <a class="carousel-control-prev" href="#carouselControls" role="button" data-slide="prev"> <span class="carousel-control-prev-icon" aria-hidden="true"></span> <span class="sr-only">Previous</span> </a>

Previous button from Paragraphs : <a class="left carousel-control" href="#myCarousel-75" role="button" data-slide="prev"> <span class="glyphicon glyphicon-chevron-left" aria-hidden="true"></span> <span class="sr-only">Previous</span> </a>

Let me know if you need more info

drmyers1 commented 5 years ago

Currently you can not re-select an image in the carousel. The only way to make changes is to delete and re-add the image. We need to be able to select the image again.