Open labboy0276 opened 5 years ago
@labboy0276 note the requirements around the interaction between the student survey and address change; we'll probably need to update the student survey to not show on the address change page (if we're keeping that a page), but to not invalidate the student survey so it will show up on the next page load after the address form is submitted.
@labboy0276 the original code added to student_survey was causing an error (you can't return FALSE
in a block build()
function implementation, it caused an error when the block was added to the page).
I reconfigured that in the commit above, but for some reason my $address_check_inactive
boolean keeps evaluating as TRUE when the address form is active.
Since I don't have an instance of the site running locally currently, was wondering if you could debug that? Wondering if it has something to do with module weight...perhaps the usfb_address_check
session variable isn't set when the student survey block code runs?
@reynoldsalec I changed the logix a little so it should be ok now, can you please test again?
Awesome, that worked @labboy0276. One thing I'm noticing is the confirmation form has markup in it; might need to pass it through something:
OK @reynoldsalec I fixed this and just pushed it up
@labboy0276 @reynoldsalec Testing Feedback:
there is a menu that is showing up on the dashboard. This menu is not displaying on production or any of our other multdevs. Here is a screenshot. on our previous instance if someone had a blank address, it have a placeholder for the address in the pop-up, so the student knew they had to update. I will try and find an old screenshot.
There seems to be a formatting issue with the student survey. Attaching screenshot
Another scenario that i encountered, is with students that had both address check and student survey. If I skipped both, I was prompted again on login. If I completed the address check but skipped the survey. I was not prompted for the survey again. I test with three different users and had the same result.
I also tested with a couple accounts that were on the student survey list but on log in they did not address check or the student survey. Here are the users names algarcia6 and tnguyen56
I had three grad students log in but only one received the address check. Here are the accounts that did not get the pop-up ctzejanda and shu16. I checked in Banner and the ctzejanda had not update the address since 2016.
Please let me know if you have any questions.
@drmyers1 I made this screen cast to explain some of the issues and how I resolved them: http://www.screencast.com/t/Mh7hmXdL83q
I still need to fix the placeholder address issue, the survey + address check issue and the student survey misalignment issues.
@labboy0276 thanks for the screen cast. I will run some additional tests on the changes you mentioned.
@labboy0276 i had two of our students that haven't tested log in and both did not get the address check pop up or the student survey. Here are the usernames: tmchen4 & dgarcia15
I have a couple more students working today that we will test with.
@drmyers1 It looks like tmchen4 confirmed today at 945 am PST && dgarcia15 I was able to get his to show up by changing the start date of the form to yesterday.
The only way to get the date to fille dint he confirm spot s by going through the process
Also @drmyers1 I can't replicate the 2 bugs:
Here is a screenshot showing me walk through this: http://www.screencast.com/t/Cf0EmWUqgfHO
@labboy0276 I will take a look and see if I can replicate again.
Also, I am going to be out of the office for the next week but @rjbain @nicholas-kebbas will provide support on this while I am out. CC @reynoldsalec
@drmyers1 I wasnt sure what to put for the empty fields, so I just used **EMPTY**
in the dialog. You can test with student scladd
Thanks, @labboy0276. We'll check it out tomorrow.
Thanks @labboy0276.
Tested with some students and noticed that one of them saw "EMPTY" appear when the "Address 2" field isn't filled out. We would not want that to appear in this case, as long as "Address 1" is filled out.
Please let me know if that makes sense and if you have any questions.
Thanks
OK @nicholas-kebbas I fixed it so empty doesn't show for address2
@labboy0276 i ran several tests for the address change. I see the address2 is working as expected. I did run into the issue again with the user 'ctzejanda'. She logged in and did not get the address check. I had set the start date to Feb 8 on the address configuration page. I also had her log in to the banner system and her local residence has not been updated since 2016. I am trying replicate with another user. I will post as soon as I have another example.
@drmyers1 OK I am curious if cas login isnt firing this. If you can replicate via CAS login, can I get the CAS logins of a cpl students?
@labboy0276 i tried testing with another student CAS account and was able to get the address pop up. I am having IT reset the ctzejanda account and will have her try again. I want confirm that it is not an account related issue on our test instance.
@labboy0276 i was able to re-test again with ctzejanda. It looks like it was problem with her profile on the test instance. We got the pop-up after the profile was updated. I will run a few more tests and get back to you with the results. Please let me know if you have any questions.
@labboy0276 i ran more tests with all our students and the address pop-up works as expected. I also tested with students that would also get the student survey and that seems to be working as well. Please let me know if you have any questions.
@drmyers1 Great, so I guess we can push this live? We will also need to copy the certs up to the live File system as well
Description
The old MyUSF D7 system used the usfb_address and usf_banner modules to present a dialogue to students once per semester prompting them to update their contact info to be updated in the Banner system.
We'll update this functionality into Drupal 8.
General Admin Workflow
admin/config/usfb_address
)General Student Workflow
Interaction with Student Survey
If a student is active for both an Address update and Survey question, we must show the Address change form first, then the Student Survey pop-up.
Resources
Address Requirements Doc