rjbatista / tm1638-library

Automatically exported from code.google.com/p/tm1638-library
141 stars 75 forks source link

Fix toTM1640 support for setDisplay function. #28

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
Run on TM1640:
byte values[] = { 73,73,73,73,73,73,73,73,73,73,73,73,73,73,73,73 };
module.setDisplay(values);

What is the expected output? What do you see instead?
Updates only the first 8 positions out of expected 16 positions.

What version of the product are you using? On what operating system?
TM1638 Library v2.1.3.zip with Arduino 1.0.3 environment.

Please provide any additional information below.
Partial fix is changing
virtual void setDisplay(const byte values[], unsigned int length = 8);
to
virtual void setDisplay(const byte values[], unsigned int length = 16);
in TM16XX.h

Original issue reported on code.google.com by Jani.La...@gmail.com on 25 Feb 2013 at 9:47

GoogleCodeExporter commented 8 years ago
I'm away from home on business, so I can't pick this up right now (don't have 
my TM1640 here, so can't really devel for it).

I promise I'll look this up and fix it as soon as I get back.

Original comment by rjbati...@gmail.com on 31 Mar 2013 at 8:15

ruedli commented 7 years ago

I am routinely using the TM1640 with three modules and using all 3x128 LEDS individually in a matrix of 25 x 5 RGB common anode LEDS with the remaining 9 LEDS individually.

I believe the library is OK, however for a TM1640 you should set the buffer with: module.setDisplay(values,16);

in your example you used: module.setDisplay(values);