search

rjbordon / techo_encuestas

0 stars 2 forks source link

Refactor ng application to follow BKMs #11

Open rjbordon opened 9 years ago

rjbordon commented 9 years ago

Tiny refactoring to be compliant with angular BKMs

rmarku commented 9 years ago

I think this is necessary. We made a little mess at the hackatong :smile:. Is there any documentation about angular BKMs? This can be extended (or maybe a new issue) for Sails.JS. I have no idea about BKMs for angular o Best practices.

rjbordon commented 9 years ago

at minimal we should refactor the ng app structure, then we can review the specific code changes we may need to redo, if we really need to. The BKMs I've use in other projects are the ones described here: https://github.com/johnpapa/angular-styleguide.

I've already started with this on a branch, work in progress, but at least I had pushed the first bits https://github.com/rjbordon/techo_encuestas/commit/82b4cdcdf753dcc2e4023ff55c232e64e67c7198 ^_^. When I finish with this I'll create a pull request so we can review the changes toghether.

One more thing, I thing we should exchange IDE code style configs as I think I'm using a different set from the one Markuuuuuus has :-)

rmarku commented 9 years ago

hahaha... I thought that with the .editorconfig file all configs would be the same, but it looks like it doesnt.

We can configure the editor with that config or share some kind of Webstorm config in the repo?