rjbs / Dist-Zilla

scary tools for building CPAN distributions
http://dzil.org/
186 stars 152 forks source link

Generates a Makefile.PL with v-prefixed versions that don't work prior to EUMM 6.67_02 #293

Closed kentfredric closed 9 years ago

kentfredric commented 10 years ago

Here: https://github.com/duckduckgo/p5-app-duckpan/issues/65

App::Duckpan has this in its generated Makefile.PL:

    "Term::UI" => "0.30",
    "Text::Xslate" => "v3.0.0",
    "URI" => "1.60",

Prior to EUMM 6.67_02, this outputs:

Unparsable version 'v3.0.0' for prerequisite Text::Xslate at Makefile.PL line 139.
Checking if your kit is complete...
Looks good
Warning: prerequisite Starman 0 not found.
Writing Makefile for App::DuckPAN
Writing MYMETA.yml and MYMETA.json

But after 6.67_02, no error is emitted.

Not sure what best solution is here.

karenetheridge commented 10 years ago

Is the Text::Xslate prereq still satisfiable? it looks like EUMM is just warning, not dying, so maybe we don't need to do anything at all.

dolmen commented 10 years ago

For reference, here is the content of the generated Makefile.PL:

   "Text::Xslate" => "v3.0.0",
rjbs commented 9 years ago

duplicate of #171