search

rjbs / Dist-Zilla

scary tools for building CPAN distributions
http://dzil.org/
186 stars 152 forks source link

find_files comes from Dist::Zilla::Role::ExecFiles #597

Closed wolfsage closed 7 years ago

karenetheridge commented 7 years ago

lol, all the time the sub in this role was useless because it was being overridden locally with a copy of the same sub.

it's been like this forever since these two packages were written back in 2010-03-22.

karenetheridge commented 7 years ago

maybe this change should be the other way, with the find_files sub disappearing in the role and replaced with requires 'find_files'; -- the role is being used as a marker for the :ExecFiles file finder to find the appropriate plugin(s) to interrogate. all that matters is that the composing classes implement find_files.

rjbs commented 7 years ago

For now, the given fix makes the most sense to me. Applied!