search

rjbs / Dist-Zilla

scary tools for building CPAN distributions
http://dzil.org/
186 stars 152 forks source link

Switch to use Feature::Compat::Try instead of Try::Tiny #717

Open Leont opened 1 year ago

Leont commented 1 year ago

This makes it «use feature 'try'» on perl 5.36 and up, and use Syntax::Feature::Try on older versions.

rjbs commented 1 year ago

I am pretty hesitant here. I think Dist::Zilla has never used experimental features, and I'm not sure I want to start now.

Leont commented 1 year ago

Fair enough, it can wait.

Would that make Syntax::Keyword::Try a better option?

rjbs commented 1 year ago

I don't know, because I'm not sure what the benefit of using this over Try::Tiny is, here. What are we getting?

Grinnz commented 1 year ago

Efficiency, ability to use return normally, avoidance of superglobals, similarity to the upcoming 'try' feature!

Grinnz commented 1 year ago

Just make sure to use Syntax::Keyword::Try not the unrelated Syntax::Feature::Try 😄

karenetheridge commented 1 year ago

not the unrelated Syntax::Feature::Try

gah! I didn't realize that existed.. we should watch out for this.

Leont commented 1 year ago

Just make sure to use Syntax::Keyword::Try not the unrelated Syntax::Feature::Try smile

Yeah I keep confusing them, have to check the author to know which one I want