fix line numbers in violation

rjbs / Perl-Critic-Tics

perl critic policies for things that make rjbs nuts

3 stars 4 forks source link

fix line numbers in violation #3

Closed otrosien closed 10 years ago

otrosien commented 10 years ago

This is the sort order of array indices used for a violation location: (Violation.pm)

Readonly::Scalar my $LOCATION_LINE_NUMBER => 0; Readonly::Scalar my $LOCATION_COLUMN_NUMBER => 1; Readonly::Scalar my $LOCATION_VISUAL_COLUMN_NUMBER => 2; Readonly::Scalar my $LOCATION_LOGICAL_LINE_NUMBER => 3; Readonly::Scalar my $LOCATION_LOGICAL_FILENAME => 4;

ATM all violations are reported to be on line 1.

rjbs commented 10 years ago

Thank you very much! I have merged #2, which covers this change and has some tests and so on. Without your PR, I would've entirely forgotten this problem or the languishing PR!