search

rjdverse / rjdemetra

R interface to JDemetra+ v 2.x
https://rjdverse.github.io/rjdemetra
52 stars 16 forks source link

Add model span when printing regarima #136

Closed TanguyBarthelemy closed 6 months ago

AQLT commented 6 months ago

Why do you want to add the model span to the print method?

TanguyBarthelemy commented 6 months ago

This information is missing in the current print. But it could be very useful to the user to specify what the span is and remind (if the user has forgotten this information) that there is one. Why not include this information?

AQLT commented 6 months ago

The information is already in the summary print method. The print method is supposed to be "simplified" (even if I think we should remove some statistics to have a very simple output) and the summary provides a more detailed output. Most of the time it will be redundant with the series span of the input time series. Moreover it is not printed in other seasonal adjustment / time series model packages. So why do you think it is not enough to have it printed in the summary method?

TanguyBarthelemy commented 6 months ago

Ok, I'll discuss it with @annasmyk. But I find that it may be a little difficult and twisted to find this information like that (you have to call another function with only the regarima part of your sai (summary(sai) doesn't return anything).

Thank you for your answer and your precision (I forgot the summary function...)

AQLT commented 6 months ago

So maybe we should implement a summary.SA() function which would only run the summary(object$regarima)?

TanguyBarthelemy commented 6 months ago

Yes maybe, but I think that this information is quite important and that it would be better if it appeared in the print. For now I will put my PR aside in this case.

annasmyk commented 6 months ago

I would be strongly in favor of it appearing in the print as well..