Add test for stopping on non-existent dir (ref #124)

rjeczalik / notify

File system event notification library on steroids.

MIT License

903 stars 128 forks source link

Add test for stopping on non-existent dir (ref #124) #125

Closed imsodin closed 7 years ago

imsodin commented 7 years ago

This does not fix anything, but tries to reproduce issue #124 in a unit test.

imsodin commented 7 years ago

@rjeczalik The error for mac/fswatcher is as expected, and apparently this test also uncovered a race in windows/readdcw watcher.

Edit: In the syncthing tests where the mac issue came up, there is also an issue with windows. It might be caused by this race, but I wasn't able to debug that one yet.

imsodin commented 7 years ago

@rjeczalik The race was simple to find/fix, but it does not fix the other issue I have with windows watches. I will upload another PR with the fix for that and trying to reproduce it (might not work, as it's racy on the filesystem/syscall level). The mac/fsevents issue remains.

imsodin commented 7 years ago

see #129