search

rjeczalik / notify

File system event notification library on steroids.
MIT License
902 stars 128 forks source link

node: Return traverse error as os.PathError #134

Closed imsodin closed 6 years ago

imsodin commented 6 years ago

Missing nodes are already reported as os.PathError. This does the same for the error returned when setting up a recursive watch with a non-recursive watcher, i.e. during traversing. The error string is the same as before, so user of this library wont notice the change. This allows to check the underlying error and which path causes the problem. An example of a use case is for Syncthing, where we want to notify the user when the error is due to hitting the inotify handler limit.

imsodin commented 6 years ago

@ppknap @rjeczalik While you're dealing with the other PR, could you also have a look at this (then we can update our vendoring all in one ;) ).

rjeczalik commented 6 years ago

I must have missed notification on this one, thanks @imsodin!