search

rjeczalik / notify

File system event notification library on steroids.
MIT License
902 stars 128 forks source link

Doesn't build on Darwin with Go 1.10beta1 #135

Closed calmh closed 6 years ago

calmh commented 6 years ago

Cgo rules have changed slightly in the upcoming Go 1.10. With the current beta1:

jb@kvar:~/e/s/g/z/notify $ go version
go version go1.10beta1 darwin/amd64
jb@kvar:~/e/s/g/z/notify $ go install
# github.com/zillode/notify
./watcher_fsevents_cgo.go:51: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal
./watcher_fsevents_cgo.go:162: cannot use nil as type _Ctype_CFAllocatorRef in argument to _Cfunc_CFStringCreateWithCStringNoCopy
./watcher_fsevents_cgo.go:163: cannot use nil as type _Ctype_CFAllocatorRef in argument to func literal

The required changes are documented here:

https://go-review.googlesource.com/c/go/+/66332

I'll file a PR fixing it shortly. (Paths in the error are from a fork.)