search

rjeczalik / notify

File system event notification library on steroids.
MIT License
902 stars 128 forks source link

Handle pointers that are now integers in Go 1.10 (fixes #135) #136

Closed calmh closed 6 years ago

calmh commented 6 years ago

The Core Services reference types became integer shaped after being pointer shaped in Go 1.9. I moved the thing out into a constant zero or nil variable according to the Go version, in order to avoid duplicating a bunch of code into separate files.

This is the required fix according to https://go-review.googlesource.com/c/go/+/66332.

This passes tests with Go 1.9.2. and 1.10beta1.

calmh commented 6 years ago

Windows test failure doesn't look related to this change.

calmh commented 6 years ago

I have no idea how to interpret the travis test failure.

rjeczalik commented 6 years ago

@calmh I'll run the tests manually on a windows box just to confirm. I think I've observed those timeouts previously, did not reproduce them outside the ci environment.

calmh commented 6 years ago

Yeah. Changes are build tagged for darwin only.

rjeczalik commented 6 years ago

Thanks @calmh! We'll need to figure out more graceful timeouts for Windows on AppVeyor, so the tests are less flaky.