Revert "Handle pointers that are now integers in Go 1.10 (fixes #135)"

rjeczalik / notify

File system event notification library on steroids.

MIT License

902 stars 128 forks source link

Revert "Handle pointers that are now integers in Go 1.10 (fixes #135)" #143

Closed calmh closed 6 years ago

calmh commented 6 years ago

The thing I did to fix compatibility for Go 1.10 has been changed again on the Go tree since. To actually build with go1.10rc1 we need to revert my thing. Sorry.

This reverts commit ff2d4d2cedc09db23cc46d3eeb8b402bca6d819d.

rjeczalik commented 6 years ago

has been changed again on the Go tree since

Interesting, I did not follow changes in Go recently. Out of curiosity, do you have a reference for the change you mention?

calmh commented 6 years ago

I don't, I just noticed that 1.10 RC1 gave me the opposite problem that I fixed for 1.10 beta-something... But we should have that noted here somewhere so let me dig a little

calmh commented 6 years ago

I think the latest relevant change is https://github.com/golang/go/commit/d162a297ed

I can't say I fully understand it, but I feel like what happened was the initial breakage in 1.10 beta1 was inadvertent and I was premature in fixing it... It would be spectacular if this changed again after 1.10 rc1

rjeczalik commented 6 years ago

@calmh Could you rebase with master please?

calmh commented 6 years ago

Done. Travis failure looks unrelated

rjeczalik commented 6 years ago

Thanks!