Closed imsodin closed 6 years ago
This is cleaner than my hack.
@rjeczalik @pblaszczyk Did you already get a chance to look at this?
@rjeczalik these changes LGTM. Could you review them and merge if OK? AFAIK @pblaszczyk won't be able to review this in the short term...
Thanks @imsodin for the fix 😃
Instead of panicking, return a stub watcher that returns a sensible error message like the "not implemented" one does.
Another approach was implemented by @calmh, in that the watcher isn't initialized initially but only on first use and the initialization function recovers from panics: https://github.com/syncthing/notify/commit/2556ab349002cb2f9c250783c06b1976fc7d23b4