rjhogan
commented
6 years ago P {margin-top:0;margin-bottom:0;}
Thanks - yes I found this problem recently with clang and was planning to post a fix soon. Regards, Robin.
From: Dougal J. Sutherland [notifications@github.com] Sent: 30 January 2018 18:54 To: rjhogan/Adept-2 Cc: Subscribed Subject: [rjhogan/Adept-2] _mm_undefined_ps missing on old clang (#7)
Packet.h has test code to define _mm_undefined_ps if it's missing on old GCC. Old Clangs, though, also don't have this instruction, causing build failures:
example Travis failure. I was able to work around it in the conda-forge package we're adding with a dumb patch, which I'm only applying for our OSX builds. You shouldn't put this in Adept, because it's incorrect (if _mm_undefined_ps is defined as a function rather than a macro, as it actually is, it'll override that definiton), but there should probably be a version check for clang too. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.
yurivict
djsutherland
Packet.hhas test code to define_mm_undefined_psif it's missing on old GCC. Old Clangs, though, also don't have this instruction, causing build failures: example Travis failure.I was able to work around it in the
conda-forgepackage we're adding with a dumb patch, which I'm only applying for our OSX builds. You shouldn't put this in Adept, because it's incorrect (if_mm_undefined_psis defined as a function rather than a macro, as it actually is, it'll override that definiton), but there should probably be a version check for clang too.