rjkroege / edwood

Go version of Plan9 Acme Editor
Other
387 stars 34 forks source link

Backward search performance is terrible using :-/xxx #398

Closed tiancaiamao closed 3 years ago

tiancaiamao commented 3 years ago

In acme, you can use right click on:+/xxx to search string xxx, it search from the forward direction. There is also a :-/xxx to seach from the backward direction.

In acme, the backword search is basically the same with the forward search. However, in edwood, :-/xxx is very slow, an order of magnitude slower than :+/xxx

paul-lalonde commented 3 years ago

That's the golang regexp library vs the hand-coded one in acme. This is probably a strong enough argument to do regexp in edwood directly, though that's at high engineering cost.

On Wed, Nov 10, 2021, 9:11 PM tiancaiamao @.***> wrote:

In acme, you can use right click on:+/xxx to search string xxx, it search from the forward direction. There is also a :-/xxx to seach from the backward direction.

In acme, the backword search is basically the same with the forward search. However, in edwood, :-/xxx is very slow, an order of magnitude slower than :+/xxx

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rjkroege/edwood/issues/398, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ6RUFD3JOLCBMTIHYNLQTULNGATANCNFSM5HZS3USA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

rjkroege commented 3 years ago

First duplicate bug! That's sort of exciting. We should fix this. Tracked in #301