search

rjkroege / edwood

Go version of Plan9 Acme Editor
Other
387 stars 34 forks source link

Rename file.Buffer.Commit #426

Closed rjkroege closed 2 years ago

rjkroege commented 2 years ago

file.Buffer.Commit and file.File.Commit do very different things. This is confusing. Introduce a new name SetUndoPoint to more accurately capture file.Buffer semantics and avoid name collision.

codecov[bot] commented 2 years ago

Codecov Report

Merging #426 (eeb3c0c) into master (b754c5e) will decrease coverage by 0.31%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   56.95%   56.64%   -0.32%     
==========================================
  Files          57       56       -1     
  Lines       10778    10670     -108     
==========================================
- Hits         6139     6044      -95     
+ Misses       4200     4189      -11     
+ Partials      439      437       -2
Impacted Files Coverage Δ
file/undo.go 85.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b754c5e...eeb3c0c. Read the comment docs.