search

rjkroege / edwood

Go version of Plan9 Acme Editor
Other
385 stars 34 forks source link

Remove HasUncommitedChanges from SaveableAndDirty #427

Closed rjkroege closed 2 years ago

rjkroege commented 2 years ago

SaveableAndDirty only needs to be true for buffers with Undo so there's no need to invoke HasUncommitedChanges. Helps with #97 because file.Buffer does not have a Commit concept.

codecov[bot] commented 2 years ago

Codecov Report

Merging #427 (e250bb0) into master (af58c46) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   56.64%   56.64%           
=======================================
  Files          56       56           
  Lines       10670    10670           
=======================================
  Hits         6044     6044           
  Misses       4189     4189           
  Partials      437      437
Impacted Files Coverage Δ
file/observable_editable_buffer.go 71.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af58c46...e250bb0. Read the comment docs.