rjkroege / edwood

Go version of Plan9 Acme Editor
Other
387 stars 34 forks source link

Fix a rendering bug with filled lines #459

Closed rjkroege closed 2 years ago

rjkroege commented 2 years ago

Inserting an actual newline at the end of a soft line-broken box no longer inserts a spurious blank line. This fixes a pernicious rendering issue.

codecov[bot] commented 2 years ago

Codecov Report

Merging #459 (2898f44) into master (0c99ef9) will increase coverage by 0.03%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
+ Coverage   58.01%   58.04%   +0.03%     
==========================================
  Files          54       54              
  Lines       10676    10684       +8     
==========================================
+ Hits         6194     6202       +8     
  Misses       4048     4048              
  Partials      434      434              
Impacted Files Coverage Δ
frame/frame.go 37.14% <ø> (ø)
frame/util.go 77.88% <ø> (ø)
frame/draw.go 26.57% <100.00%> (+0.51%) :arrow_up:
frame/insert.go 86.13% <100.00%> (+0.42%) :arrow_up:
frame/ptofchar.go 80.82% <100.00%> (ø)
frame/select.go 12.60% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.