search

rjkroege / edwood

Go version of Plan9 Acme Editor
Other
387 stars 34 forks source link

Don't backspace if there's a selection #478

Closed rjkroege closed 1 year ago

rjkroege commented 1 year ago

Fix a persistent niggle in the UI: pressing backspace when there's a non-zero selection, merely delete the selection and don't delete the additional character.

codecov[bot] commented 1 year ago

Codecov Report

Merging #478 (0ac0837) into master (10ad0fa) will decrease coverage by 0.02%. The diff coverage is 25.00%.

:exclamation: Current head 0ac0837 differs from pull request most recent head 6bad303. Consider uploading reports for the commit 6bad303 to get more accurate results

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   58.10%   58.09%   -0.02%     
==========================================
  Files          53       53              
  Lines       10672    10676       +4     
==========================================
+ Hits         6201     6202       +1     
- Misses       4037     4040       +3     
  Partials      434      434
Impacted Files Coverage Δ
text.go 48.35% <25.00%> (-0.10%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

paul-lalonde commented 1 year ago

Could have sworn I've fixed this one three times now.

On Sat., Mar. 4, 2023, 2:06 p.m. Robert Kroeger, @.***> wrote:

Fix a persistent niggle in the UI: pressing backspace when there's a non-zero selection, merely delete the selection and don't delete the additional character.

You can view, comment on, or merge this pull request online at:

https://github.com/rjkroege/edwood/pull/478 Commit Summary

File Changes

(1 file https://github.com/rjkroege/edwood/pull/478/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/rjkroege/edwood/pull/478, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ6RUGPWC3R4VEN6SQDYFDW2O4FNANCNFSM6AAAAAAVPY2OZA . You are receiving this because you are subscribed to this thread.Message ID: @.***>