search

rjkroege / edwood

Go version of Plan9 Acme Editor
Other
383 stars 34 forks source link

Event file writes sometimes have Location in Arg #487

Closed paul-lalonde closed 1 year ago

paul-lalonde commented 1 year ago

We can get: "C1:M C2:x Q0:48 Q1:52 OQ0:49 OQ1:49 Flag:11 Text:Look Arg:/Users/flux/dev/edwood/cmd/win/win Loc:/Users/flux/dev/edwood/cmd/win/+win:#117,#120"

instead of "C1:M C2:x Q0:48 Q1:52 OQ0:49 OQ1:49 Flag:11 Text:Look Arg:/Users/flux/dev/edwood/cmd/win/+win:#117,#120" Loc:/Users/flux/dev/edwood/cmd/win/+win:#117,#120"

Working on a reliable repro - this showed up cleanly (and repeatably) while working on win.

rjkroege commented 1 year ago

I'm already planning on looking at some of this code for #470 so I'll take this.

paul-lalonde commented 1 year ago

I believe I've found the cause - the a and aa variables returned from getargs() in Execute() appear to be reversed. I haven't finished tracing it though well enough to be happy to commit the change. There's another bug between here and the golang win that's causing the "Send" to show up when chording it. Still digging.

Paul

On Mon, May 1, 2023, 4:06 p.m. Robert Kroeger @.***> wrote:

I'm already planning on looking at some of this code for #470 https://github.com/rjkroege/edwood/issues/470 so I'll take this.

— Reply to this email directly, view it on GitHub https://github.com/rjkroege/edwood/issues/487#issuecomment-1530517587, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJ6RUHIF4SFTF6E5QBLCDDXEA6V7ANCNFSM6AAAAAAXOLMOYQ . You are receiving this because you authored the thread.Message ID: @.***>