Enable warnings as errors

[rjmurillo]

• Updated .editorconfig to set policy on some duplicate warnings for TODO. Borrowed from #89 to make merging easier
• Updated cases where nullability was incorrect (something could be passed as null but wasn't, something was marked as nullable but wasn't). Where possible added asserts so we can catch cases when they arise.
• Removed <NoWarn> from Moq.Analyzers.csproj
• Added <TreatWarningsAsErrors> and MSBuildTreatWarningsAsErrors elements to CodeAnalysis.props
  • Set each to true when MSBuild property $(ContinuousIntegrationBuild) is true from DotNet.ReproducibleBuilds package

[codacy-production[bot]]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
:white_check_mark: +0.35% (target: -1.00%)	:x: 90.48% (target: 95.00%)

Coverage variation details

| | Coverable lines | Covered lines | Coverage | | ------------- | ------------- | ------------- | ------------- | | Common ancestor commit (9c4dde830ea9828e1e16ce3af26e6c05f2183ad6) | 400 | 371 | 92.75% | | | Head commit (db75e30c2539d0904638aa6110b6d4e9b6fd892b) | 406 (+6) | 378 (+7) | 93.10% (**+0.35%**) | **Coverage variation** is the difference between the coverage for the head and common ancestor commits of the pull request branch: ` - `

Diff coverage details

| | Coverable lines | Covered lines | Diff coverage | | ------------- | ------------- | ------------- | ------------- | | Pull request (#91) | 21 | 19 | **90.48%** | **Diff coverage** is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: `/ * 100%`

See your quality gate settings    Change summary preferences

---

_{:rocket: Don’t miss a bit, follow what’s new on Codacy.}

_{Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more}

[rjmurillo]

@MattKotsenas we can turn off Codacy when we get reporting of coverage up as something we can gate on. We can also check in a config file to keep the integration sane. I disabled the Sonar analyzer, so I'm really just interested in code coverage and some obvious linting things in YAML, PowerShell, and JSON files. The recommendation from Codacy is to check in the configuration for the tools used themselves and it'll pick them up.