rjnl / moodle-paygw_chargebee

Other
0 stars 1 forks source link

Handle privacy #1

Closed rjnl closed 1 year ago

rjnl commented 2 years ago

Use privacy provider

danmarsden commented 1 year ago

looks like privacy provider is only partially implemented?

you have completed the bare-minimum (metadata) but the export/delete components of the privacy api are not complete... I personally lean more towards the reject part of the fence for payment plugins on this - I think correct implementation of the privacy api is pretty important for plugins like this.

danmarsden commented 1 year ago

it also looks like this plugin passes the users name and email to chargebee which definitely should be covered in the privacy api under the get_external_link stuff: https://moodledev.io/docs/apis/subsystems/privacy/#indicating-that-you-export-data-to-an-external-location

rjnl commented 1 year ago

Thanks Dan. I'll update the privacy handling of the plugin.

rjnl commented 1 year ago

Fixed in https://github.com/rjnl/moodle-paygw_chargebee/commit/2792708cf292d4502380983bda5178865789f029