search

rjones30 / HDGeant4

Geant4 simulation for the GlueX experiment
1 stars 8 forks source link

Ijaegle hdgeant4 #24

Closed igjaegle closed 4 years ago

igjaegle commented 4 years ago

Recalculate the particle mass to avoid warnings for mass-less particles

rjones30 commented 4 years ago

Hello Igal,

You submitted this PR to my private repo, rjones30/HDGeant4. Would you mind please submitting it to the JeffersonLab/HDGeant4 repo instead?

thank you, -Richard Jones

On Fri, Jan 3, 2020 at 1:21 PM igjaegle notifications@github.com wrote:

Recalculate the particle mass to avoid warnings for mass-less particles

You can view, comment on, or merge this pull request online at:

https://github.com/rjones30/HDGeant4/pull/24 Commit Summary

  • local changes to make work + to run optical photons as primaries
  • use visualization in GNUmakefile
  • generate optical photons as primaries using ID = 1050
  • Merge pull request #14 from JeffersonLab/fix_build_errors_rtj
  • GNUmakefile.OSX: define get-particle-iterator macro
  • det. efficiency at production stage for the DIRC
  • Merge branch 'dirc_rd'
  • Switch suffixes to .dylib and removed 64 from lib names.
  • Merge pull request #15 from JeffersonLab/ns/OSXMakefile
  • Merge pull request #16 from JeffersonLab/davidl_OSX
    • src/hdgeant4.cc [rtj]
    • src/CobremsGeneration.cc [rtj]
    • src/GlueXPrimaryGenerator.cc [rtj]
    • src/GlueXStackingAction.cc [rtj]
    • src/GlueXSensitiveDetectorDIRC.cc, src/GlueXStackingAction.cc [rtj]
  • Merge pull request #18 from JeffersonLab/correct_runno_init_rtj
  • Merge pull request #19 from JeffersonLab/bunch_of_bug_fixes_rtj
  • Merge pull request #20 from JeffersonLab/dirc_code_cleanup_rtj
  • Port change from using /CDC/cdc_drift_parms to /CDC/drift_parameters that was applied to HDGeant
  • Merge pull request #21 from JeffersonLab/sdobbs_more_cdc_fixes
  • [rtj] - disable the action of "SAVEHITS 0" card in control.in from
    • correct the unit conversions between the units convention for the
  • Merge pull request #23 from JeffersonLab/beam_bg_cpuhog_fix_rtj
    • suppress the generation of the RFtime tag in the hddm output file,
  • Merge pull request #26 from JeffersonLab/suppress_RFtime_rtj
    • remove the DISABLE switch on the PostStepDoIt trigger
  • Merge pull request #27 from JeffersonLab/fix_GENBEAM_bugs_rtj
  • Add a -L switch to the link flags to explicitly name the directory in
    • src/hdgeant4.cc [rtj]
  • Merge pull request #28 from JeffersonLab/fix_nvidia_driver_loadfail_rtj
  • Merge pull request #29 from JeffersonLab/python_link_flags
  • effectively no changes
    • src/CobremsGeneration.cc,hh [rtj]
    • src/GlueXPhotonBeamGenerator.cc [rtj]
    • src/GlueXPrimaryGeneratorAction.cc [rtj]
    • control.in [rtj]
  • Merge pull request #30 from JeffersonLab/support_amorphous_radiator_rtj
    • src/GlueXBeamConversionProcess.cc [rtj]
  • Merge pull request #31 from JeffersonLab/fix_infinite_loop_rtj
    • fix the logic for handling the end-of-file condition on hddm input.
  • Merge pull request #32 from JeffersonLab/fix_hddm_eof_handling_rtj
  • Add TAC to list of libraries searched.
  • Merge pull request #33 from JeffersonLab/add_TAC
    • test/control.in [rtj]
  • Merge pull request #34 from JeffersonLab/amorphous_rad_rtj
    • src/GlueXPhotonBeamGenerator.cc, hh [rtj]
  • Merge pull request #35 from JeffersonLab/get_RFref_from_ccdb_rtj
    • src/GlueXDetectorConstruction.cc [rtj]
  • Merge pull request #36 from JeffersonLab/add_fcal_truth_light_guide_rtj
    • src/GlueXPseudoDetectorTAG.cc [rtj]
    • src/GlueXPrimaryGeneratorAction.cc [rtj]
    • src/GlueXPrimaryGeneratorAction.cc [rtj]
  • Merge pull request #37 from JeffersonLab/fix_tag_time_bug_Elton_rtj
    • g4py/cobrems.py, g4py/hdgeant4.py [rtj]
  • Merge pull request #38 from JeffersonLab/restore_python_module_functionality_rtj
    • src/GlueXDetectorConstruction.cc, .hh [rtj]
  • Merge pull request #39 from JeffersonLab/hdds_from_ccdb_rtj
    • src/GlueXPrimaryGeneratorAction.cc [rtj]
    • GNUmakefile [rtj]
  • Merge pull request #40 from JeffersonLab/repair_broken_makefile_rtj
    • src/MyPrimaryPionZapper.cc, .hh [rtj]
  • src/CobremsGeneration.hh, .cc [rtj]
  • Add search of sqlite3 and SQLiteCpp libraries.
  • Merge pull request #41 from JeffersonLab/sqlitecpp_standalone
    • GlueXPhotonBeamGenerator.cc [rtj]
  • Merge pull request #42 from JeffersonLab/photon_beam_generator_fix_rtj
    • src/CobremsGeneration.cc [rtj]
  • Merge pull request #43 from JeffersonLab/improved_diamond_lattice_constant_rtj
    • fix the titles of some histograms that are mis-labeled [rtj]
    • make adjustment to the applyBeamCrystalConvolution() method so that
    • fix a bug in the coherent beam generator that let the polarization
  • Merge pull request #44 from JeffersonLab/cobrems_generator_fixups_rtj
    • add ability to read the run number from the input hddm file [rtj]
    • remove definition of a method that was never implemented, never used
    • src/utils/genBH.cc [rtj]
    • changed to only build utils if explicitly requested, as "make utils"
  • Merge pull request #45 from JeffersonLab/new_genBH_Bethe_Heitler_generator_rtj
    • add some methods related to the LPM effect [rtj]
  • Search custom location for sqlite library at link time and run time.
  • Merge pull request #46 from JeffersonLab/LPM
  • Merge pull request #47 from JeffersonLab/find_sqlite
    • GlueXPhotonBeamGenerator.cc, .hh [rtj]
  • Merge pull request #48 from JeffersonLab/new_UI_command_rtj
    • add print statements that empirically fix a race condition when
  • Merge pull request #49 from JeffersonLab/new_UI_command2_rtj
    • change double to LDouble_t to agree with the standard double type
    • change double to LDouble_t anywhere it might affect rounding errors in
    • put back initialization of the e3 recoil TLepton in the case of atomic
  • Merge pull request #50 from JeffersonLab/pair_conversion_bug_fixes_rtj
  • Change for building against halld_recon rather than sim-recon.
    • fix a bug in the way GluexPrimaryGenerator was shifting the vertex
    • add a retry loop to GlueXPrimaryGenerator::GeneratePrimaryVertex such
  • Merge pull request #56 from JeffersonLab/fix_vertex_timing_bug_rtj
    • complete the implementation of the correct vertex timing policy in the
    • add protection against race conditions during construction and
    • change hit timing merge algorithm from "take the earliest" to
  • Merge pull request #59 from JeffersonLab/update_fcal_hit_merge_timing_rtj
    • update the old truth hits naming scheme, left behind in some comments [rtj]
  • Merge pull request #61 from JeffersonLab/split_sim-recon
  • Merge branch 'master' of https://github.com/JeffersonLab/HDGeant4
  • Merge pull request #62 from JeffersonLab/maintenance_fixes_rtj
    • trivial fix to comments, nothing else [rtj]
    • collection of several bug fixes and variable renames, in the process
  • Merge pull request #63 from JeffersonLab/fdc_tracking_bug_fixes_rtj
    • include the missing include [rtj]
  • Merge pull request #64 from JeffersonLab/fdc_tracking_bug_fixes_rtj
    • removed unused array from GlueXSensitiveDetectorFDC.cc [rtj]
  • Merge pull request #69 from JeffersonLab/fixes_for_lubomir_rtj
    • GlueXPrimaryGeneratorAction.cc
  • Merge branch 'master' of https://github.com/JeffersonLab/HDGeant4
  • Merge pull request #70 from JeffersonLab/add_etaprime_and_others_rtj
    • G4fixes/G4ParallelWorldProcess.cc [rtj]
    • update code to compile against G4.10.04.p02 [rtj]
  • Merge pull request #71 from JeffersonLab/fix_for_G4_optical_photon_tracking_1_rtj
  • Merge pull request #72 from JeffersonLab/upgrade_hdgeant4_to_G4.10.04.p02_RTJ
    • these are the patch files needed to build hdgeant4 against
  • Merge pull request #73 from JeffersonLab/patches_for_g4_10_04_02_rtj
    • fill in the md5simulation field of the geometry tag with the md5
    • update the fdc drift time - distance relation using the parameters
    • remove some faulty conditionals in the G4IntersectingCone solver for
    • fix a fdc chamber indexing bug that was killing the efficiency of
  • Merge pull request #76 from JeffersonLab/fix_fdc_indexing_bug_rtj
    • the following updates were required to ALL of our hits classes and the
    • enabled more verbose printout during geometry initialization.[rtj]
    • insert /usr/lib64 explicitly into the link list, otherwise starting
  • Merge branch 'master' of https://github.com/JeffersonLab/HDGeant4 into primary_pion_zapper
  • Merge pull request #77 from JeffersonLab/G4_10_04_G4THITSMAP_API_CHANGE_RTJ
  • Merge pull request #78 from JeffersonLab/debug_enhancements_rtj
  • Merge pull request #79 from JeffersonLab/eliminate_linker_warnings_rtj
  • Merge remote-tracking branch 'origin/master' into primary_pion_zapper
    • src/MyPrimaryPionZapper.cc, .hn
    • better to identify a decay process by its type than by the specific
  • Merge pull request #80 from JeffersonLab/add_mc_vertex_info_rtj
  • Merge pull request #81 from JeffersonLab/use_decay_type_not_class_rtj
    • add error messaage if user tries to build without first creating the
  • Merge pull request #82 from JeffersonLab/makefile_and_misc_fixes_rtj
    • import updates related to the new DIRC geometry and hits package,
    • add new support for custom generation of Cerenkov photons in the DIRC,
    • the GlueXHitDIRCpoint object has been superseded by the GlueXHitDIRCbar, so
    • change selective compilation flag DIRCTRUTH to DIRCTRUTHEXTRA to
    • fix hddm writer to accommodate recent changes to event.xml for the
  • Merge pull request #83 from JeffersonLab/new_dirc_functionality_rtj
    • stop making zero-energy hits in the fcal -rtj
  • Initial version for the DIRC LED generator
  • Initial version of DIRC LED generator
  • Merge pull request #84 from JeffersonLab/drop_zero_energy_fcal_hits_rtj
  • libgfortran.so must be searched because of fortran code in CCAL library.
  • Merge pull request #85 from JeffersonLab/add_search_gfortran_library_MMI
  • improve feedthrough control
  • DIRC LED generator: put in LED pulse shape and cable delay; modified sensitive volumes to reflect changes in the optical box HDDS geometry logical structure
  • Merge remote-tracking branch 'origin/master' into yunjiey_dirc
  • improved control over DIRCLED card control with more flexibility
  • Merge pull request #86 from JeffersonLab/yunjiey_dirc
    • Add 3 new fields to the end of the BEAM card in control.in [rtj]
  • Merge pull request #88 from JeffersonLab/new_beam_card_fields_rtj
    • fix an inconsistency between the hits generation code here and what is
  • Merge pull request #91 from JeffersonLab/fix_start_counter_time_constants_rtj
    • remove debug print statements that were left behind after the
  • Merge pull request #92 from JeffersonLab/remove_debug_printfs_rtj
    • removed spaces from name of Parallel Word 1 process,
    • add verbose print statements, similar to the distribution
    • remove spaces from custom process names, use CamelCase [rtj]
    • fix the PostStepDoIt summary to properly report the processes
    • fix a bug in G4CoupledTransportation where it clears the internal
  • Merge pull request #95 from JeffersonLab/fix_g4_tracking_bug_jz_rtj
    • remove the nm-scale inclination that I was adding to the vertical
    • adopt the fix that the G4 development team came up with in response
    • small adjustment to the light yield for electromagnetic shower
    • propagate patch from downstream distro update to these releases. [rtj]
    • keep a copy of my proposed fix to bug-2111 for the record. [rtj]
  • Merge pull request #96 from JeffersonLab/G4IntersectingCone_bug_fix_from_G4_team_rtj
    • fix an obscure bug in the generation of tagger hit times, where
  • Merge branch 'master' of https://github.com/JeffersonLab/HDGeant4
  • Merge pull request #98 from JeffersonLab/tagger_timing_bug_fix_rtj
    • last small tweak to fcal shower response to match yields in hdgeant [rtj]
  • Merge pull request #99 from JeffersonLab/fix_lightguide_pulse_timing_rtj
    • change bcal shower timing to use energy-weighted times,
  • Merge pull request #100 from JeffersonLab/bcal_timing_fixes_rtj
    • add support for the SKIP card in control.in [rtj]
  • Merge pull request #112 from JeffersonLab/support_for_skip_card_rtj
    • add documentation for how the simulation run number is derived
    • field maps for the PS, tagger, and solenoid should come from ccdb
    • switch the order of precedence between RUNNO and RUNG in the docs
    • fix a typo in control.in [rtj]
  • Merge pull request #114 from JeffersonLab/run_number_info_rtj
    • one last fix to the way run numbers are assigned, based on
  • Merge pull request #116 from JeffersonLab/run_number_info_rtj2
    • add new static method SetStartingSeeds() to allow the user to set
    • send the starting seeds to GlueXUserEventInformation through
    • make some desirable settings the default [rtj]
  • Merge pull request #120 from JeffersonLab/fix_random_seeds_initialization_rtj
    • import a fix for optical material properties from Justin [rtj]
  • Merge pull request #124 from JeffersonLab/optical_material_propertiex_fix_from_justin_rtj
    • add new ForwardTOF volume FTOL to support new tof geometry [rtj]
    • GlueXSensitiveDetectorFTOF.cc changes to support TOF upgrade [rtj]
    • reduce the amount of verbose output at startup in hdgeant4.cc [rtj]
  • Merge pull request #126 from JeffersonLab/tof_upgrade_fixes_rtj
    • add new particle support for nuclear ions -rtj-
  • Merge pull request #128 from JeffersonLab/support_for_nuclear_ions_rtj
    • don't look at files in src/G4debug [rtj]
    • fix spelling of particle name from "muon" to "mu" [rtj]
    • add a warning if a particle in the input file mc record
  • switch off printing of random seed for every event (thanks Naomi!)
  • Merge pull request #130 from JeffersonLab/aaust_verbosity
  • Merge pull request #129 from JeffersonLab/warn_on_bad_input_particles_rtj
  • Changes to CCAL parameters to match G3
  • Merge pull request #131 from JeffersonLab/ijaegle_ccal_params
    • allow pdg types greater than 999999 [rtj]
  • Merge pull request #132 from JeffersonLab/allow_ions_to_propagate_rtj
  • add TRD library
  • Merge pull request #133 from JeffersonLab/add_trd_library
    • fix missing header file in genBH.cc, also add DANALIBs to link list [rtj]
    • add debug capability to the GlueXPhysicsList class [rtj]
    • reduce the resolution on the mass check for primaries [rtj]
    • move inline GetParticle methods into the implementation file,
  • Merge pull request #136 from JeffersonLab/fix_elton_primakov_sim_rtj
  • Check mass difference w/o warning for massless particle

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rjones30/HDGeant4/pull/24?email_source=notifications&email_token=AB3YKWHXD4LWIOI3UKJLGMLQ356ZVA5CNFSM4KCQL4MKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ID5TYDQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3YKWBMSWM6IBGIEIP2JUTQ356ZVANCNFSM4KCQL4MA .