rjones777 / pwp-capstones

0 stars 0 forks source link

SUMMARY #4

Open ad3429 opened 6 years ago

ad3429 commented 6 years ago

Criteria 1: Valid Python Code

Score Level: 4/4

Criteria 2: Implementation of Project Requirements

Score Level: 4/4

Comment(s): Nice job implementing the requirements of the project, and also paying close attention to details such as checking for invalid values.

Criteria 3: Software Architecture

Score Level: 4/4

Comment(s): Nice job separating your code in different classes and functions, and keeping it very organized! Also nice job with implementation details, such as initializing the max_value to negative infinity rather than a value such as 0 which many learners have been doing.

Criteria 4: Uses Python Language Features

Score Level: 4/4

Comment(s): Great use of python language features.

Overall Score: 16/16

Overall great job! I have made some comments about your code in the "Issues" section above. Most of the issues are quite minor and just suggestions on how to further improve your python code. You successfully implemented all of the requirements of the project, and It's very clear that your python skills have been improving. Make sure to keep up the good work!

rjones777 commented 6 years ago

Many thanks for the review and comments. I am anxious to keep on going with the classes and have already been working through the Beta courses with Matplotlib and Numpy. Our entire Dev-Ops infrastructure at my company is built on Python (2.7 unfortunately) and Django portals and I’m the Director of Infrastructure and Application Support for over 45 offices. My forte is networking and hardware, mostly Cisco iOS but needed to diversify my skill set to carry over into the development engineers. I am really enjoying this topic and this website. One thing that I struggled with and I’m not sure if it was just my brain or what but the bulk of the material and lessons in this course (like 90%) we on basic Python syntax and the last bit threw us into OOP, classes, objects, methods, etc, which was very difficult for me to assimilate. The capstone I picked that allowed me to not have to use the clunky Jupiter Notebook ended up being like 95% knowledge on OOB and was difficult in my mind as it seemed like the little bit that was covered in the end of the course on OOB was not enough. Thank god I got to ask a zillion questions to my developer staff and have them give their loose take on the topic to help me see clearer. I would suggest that possibly the OOP topics at the end of the course expand more and become a longer topic for others.

Thanks again and look forward to many more courses with you guys. Oh...almost forgot...when do they decide if the Beta courses become full classes? I’m immersed completely in those now for data science in python.

Sincerely, Rob Jones Memphis, TN