rjp44 / open-follow

GNU Affero General Public License v3.0
0 stars 0 forks source link

Unfollowable mastodon users appear in lists #22

Open rjp44 opened 1 year ago

rjp44 commented 1 year ago

Describe the bug Some found matches generate a 403 from the home mastodon host when we try to follow them, not sure why

To Reproduce Variety of possible causes, some of which we should be able to detect, some we can't. Are they people we are already following, but are not matching on, so the second one is idempotent, is it an ID mismatch, or are they all genuniely people who have blocked the user

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

rjp44 commented 1 year ago

Think this is somewhat improved by fe588cfc250357ab4b0690d68c3b3ae432642a93 I think there was a logic error that I thought user IDs were global and maybe they are local to the server we first looked up the user on. Two pass follow now where we (re-)query search to get a fresh ID before posting to follow. This seems to fix most of the cases but there are still edge cases where a user is on follower approvals that we should handle better.