search

rjpbonnal / bioruby-samtools

Porting of samtools-ruby to BioRuby. Binder of samtools for ruby, on the top of FFI -from original project-
Other
33 stars 23 forks source link

jruby changed RUBY_DESCRIPTION-- need to update regex to determine library extension #18

Closed bpow closed 11 years ago

bpow commented 11 years ago

The jruby 1.6.8 RUBY description looked something like: jruby 1.6.8 (ruby-1.8.7-p357) (2012-09-18 1772b40) (Java HotSpot(TM) 64-Bit Server VM 1.7.0_09) [linux-amd64-java]

However, with 1.7.0, it is changed to: jruby 1.7.0 (1.9.3p203) 2012-10-22 ff1ebbe on Java HotSpot(TM) 64-Bit Server VM 1.7.0_09-b05 [linux-amd64] or on OS X: jruby 1.7.0 (1.9.3p203) 2012-10-22 ff1ebbe on Java HotSpot(TM) 64-Bit Server VM 1.6.0_37-b06-434-10M3909 [darwin-x86_64]

The code for loading the shared library needs to be updated (current code looks for /linux.*java/ or /darwin.*java/, perhaps the regex could be something like /jruby.*linux/?).

homonecloco commented 11 years ago

I just had a look on the patch, would it be worthy to keep compatibility with the old and new formats?

homonecloco commented 11 years ago

Oh... I just had a better read.... It makes sense... I'll accept tphe pull request.