search

rjray / rpc-xml

A Perl implementation of the XML-RPC specification
https://metacpan.org/release/RPC-XML
24 stars 14 forks source link

Added xmlrpc request string as object property #13

Closed enrico-sorcinelli closed 3 years ago

enrico-sorcinelli commented 6 years ago

Hi, this PR aims to add XML-RPC request string as object property _xmlrcp_request_as_string after the simple_request() method call. In fact, if first argument of the method above isn't a RPC::XML::request object itself (so we can use as_string method), it seems there isn't a possibility to retrieve the string sent to the server.

rjray commented 3 years ago

Merged. I noted that you misspelled the property as _xmlrcp_request_as_string rather than _xmlrpc_request_as_string. I'll fix that.

rjray commented 3 years ago

This has me looking at this code again after several years. I realize that your patch could lead to some memory issues if a person is (for example) streaming a really large file in a request. I'm going to add to your code so that this is controlled by a configuration parameter in RPC::XML::Client::new(). I hope that this will still meet your needs.