rjrouquette / rgb_matrix_udp

udp based rgb panel driver using raspberry pi
The Unlicense
10 stars 3 forks source link

Image/video quality #6

Closed arahasya closed 4 years ago

arahasya commented 4 years ago

Hi again Robert, I am now using your driver to display photos and videos. When I compare the same content with rpi-rgb-led-matrix using active adapter, the later showed better picture quality. The difference isn't big but still visible.

I have set the clock at 19200000 and tried different refresh rates from 275 (max) to 80. At 80 the colour leakages reduce a bit but still the overall contrast seems better with rpi-rgb-led-matrix It is hard to capture the difference with phone camera but I have tried. Please ignore the colour patch when I am using your adapter with 4 chains. It is display problem. With other library there are only 3 chains so that patch is not used.

comparison.zip

rjrouquette commented 4 years ago

So fwiw, the "refresh rate" in the DPI config line has no effect on the panel scan rate or the hardware PWM. You can try further reducing the pixel clock to 9.6 MHz (9600000) and see if that helps.

I do agree that your top chain appears to have ESD damage judging by the bright line artifacts and the discoloration.

rjrouquette commented 4 years ago

I have a panel with similar ESD damage. I'm currently writing a utility to display test patterns so I can determine if your color issues are a software issue or a hardware issue. 497F713E-EF69-4C55-B192-3DA767A0EC50

rjrouquette commented 4 years ago

So it looks like your color issue is because you are using createPwmLutLinear() which is only for hardware debugging purposes. You need to use createPwmLutCie1931() to make the color correct. I've pushed the change, and I'll provide comparison images in a moment.

rjrouquette commented 4 years ago

With Linear PWM: 419970BE-758A-43F6-B0DF-17E4BC51512C

With CIE1931: F908A795-D3EF-403B-B3A3-56ADBF5E6DD3

It's hard to tell from the images, but the linear PWM creates washed-out gradients.

arahasya commented 4 years ago

Thanks. I will try out this soon on my display. Facing some technical issues right now