rjs-team / rjs

Native Javascript environment using Rust and Mozilla's SpiderMonkey JS engine.
9 stars 3 forks source link

Clippy lints, style fixes, dead code/comment removals #13

Closed ErichDonGubler closed 6 years ago

ErichDonGubler commented 6 years ago

This MAY or MAY NOT actually break things...let's test the CRAP out of this.

ErichDonGubler commented 6 years ago

Since I'm still not sure what behavior I'm looking for...does everything look good here from the manual testing side? Were there any regressions?

I'm trying to get this to compile on my work machine -- looks like I would need VS 2013, since that's the latest mozjs seems to support ATM.

ErichDonGubler commented 6 years ago

Ping: @ricochet1k

ricochet1k commented 6 years ago

I haven't tried running this branch yet.

ricochet1k commented 6 years ago

It seems to run about the same as current master, lets just get this in.

ricochet1k commented 6 years ago

Okay, so I tried to fix the merge conflicts, but seems github has a bug.

ErichDonGubler commented 6 years ago

Woot!