Remove nightly dependencies

rjs-team / rjs

Native Javascript environment using Rust and Mozilla's SpiderMonkey JS engine.

9 stars 3 forks source link

Remove nightly dependencies #15

Open ErichDonGubler opened 6 years ago

ErichDonGubler commented 6 years ago

This issue will probably be pretty long-lived, as there are several features we use that rely upon nightly:

[ ] #![feature(const_fn)]
[ ] #![feature(fnbox)]
[x] #![feature(libc)] <- perhaps we could fix this by using the libc crate?
[ ] #![feature(refcell_replace_swap)] <- waiting for landing in stable
[x] #![feature(trace_macros)] <- This could probably be removed easily.
[x] #![feature(alloca)] <- We almost certainly don't actually need this...
[ ] mozjs is currently nightly-only.

ricochet1k commented 6 years ago

trace_macros doesn't need to stay there, it is only used occasionally for macro debugging. fnbox is used in a few places because it seems impossible to send fns across thread boundaries otherwise. refcell_replace_swap is probably not necessary. I don't remember what const_fn is, and I don't know anything about libc.

ErichDonGubler commented 6 years ago

@ricochet1k: const_fn is being used in a few places (looks like mostly jsclass.rs) -- not sure if we need it yet.

ErichDonGubler commented 6 years ago

@ricochet1k: refcell_replace_swap is going to land in stable soon -- it looks like it'll enter beta with the next release: https://github.com/rust-lang/rust/pull/46517

ErichDonGubler commented 6 years ago

Added alloca, since I see that was added.

Seems like we don't really need it, though?

sagudev commented 4 years ago

I think this issue can be closed now. #32