search

rjsf-team / react-jsonschema-form

A React component for building Web forms from JSON Schema.
https://rjsf-team.github.io/react-jsonschema-form/
Apache License 2.0
14.39k stars 2.2k forks source link

material-ui alternative date widget needs fixing #1727

Closed epicfaace closed 2 years ago

epicfaace commented 4 years ago

Description

Currently, it looks like this:

image

delyanr commented 4 years ago

Looking through the docs, it is not quite clear why we need alternative pickers. Is that to support older browsers? If so, keep in mind that Material UI and Ant Design do not support older browsers than IE11, and their native pickers already work with IE11.

doncesarts commented 4 years ago

For me it is not clear why this library even needs to support material-ui , I would argue it is out of the scope of this project. The fact that it provides the capability to use any theme should be enough. Any custom implementation of a theme can be handle in a separate repository/library .

Reviewing the last issues added to this repository , many of them are related to material-ui, not all the users of this project are interested on that feature. From my perspective I think that is more important to address issues/bugs related to the core package, and give the opportunity to others to open / handle / manage their priorities regarding to material-ui theme on their own repository.

epicfaace commented 4 years ago

@doncesarts Yes, @rjsf/core is the package with the core functionality -- others can make their own themes in their own repos, but @rjsf/material-ui is an "officially" supported theme. See this for original context for why the decision was made to keep everything in one repository: https://github.com/rjsf-team/react-jsonschema-form/issues/1222#issuecomment-511054781

ronny-rentner commented 4 years ago

So what is the plan here? Use the none-native datepicker UI so it also works on Firefox, Safari and Opera?

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local

https://material-ui.com/components/pickers/

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please leave a comment if this is still an issue for you. Thank you.