search

rjsf-team / react-jsonschema-form

A React component for building Web forms from JSON Schema.
https://rjsf-team.github.io/react-jsonschema-form/
Apache License 2.0
14.3k stars 2.19k forks source link

required question #3317

Closed epicfaace closed 1 year ago

epicfaace commented 1 year ago

Should this line of code use required or schemaRequiresTrueValue? https://github.com/rjsf-team/react-jsonschema-form/blob/main/packages/core/src/components/widgets/CheckboxWidget.tsx#L44

We should also harmonize this across teams

heath-freenome commented 1 year ago

@epicfaace I believe they should use the latter since the comments are pretty instructive as to why (see this PR for its origination). I'm just curious whether all of the themes have this issue in them. I do know that some of them use required and some (like antd and fluent-ui ignore required since the component that they use does not support it). I'm guessing that we probably want all the themes to be consistent?

epicfaace commented 1 year ago

Sounds good, thanks