search

rjust / defects4j

A Database of Real Faults and an Experimental Infrastructure to Enable Controlled Experiments in Software Engineering Research
MIT License
729 stars 301 forks source link

Lang-34's buggy version is incomplete #619

Open zeyugao opened 3 weeks ago

zeyugao commented 3 weeks ago

Original issue: https://issues.apache.org/jira/browse/LANG-586

The patches: https://github.com/apache/commons-lang/commit/5c3ec55e15922c58bb2f39145de9fe641840bb50 and https://github.com/apache/commons-lang/commit/a2bb711aee6621b21cdd22e6d7e4bff2f7236235

But in defects4j, only the latter commit is cherry-picked to be reverted: https://github.com/rjust/defects4j/blob/master/framework/projects/Lang/patches/34.src.patch , ignoring the huge changes in the former commit

rjust commented 3 weeks ago

Hi @zeyugao,

This observation is aligned with the bug-mining approach used to curate the dataset.

Multi-commit bugs are certainly interesting, and we would welcome contributions that add these types of bugs to the dataset.

Alternatively, or in addition, augmenting the existing metadata to indicate which bugs in the dataset are partial (i.e., part of a broader set of changes) would be a great contribution as well. Do you want to open a PR that introduces new metadata? Happy to iterate over design decisions for how to incorporate the information about partial bugs.