search

rjw57 / yt

Experiments with the YouTube API
MIT License
83 stars 25 forks source link

Adding omxplayer functionality. #1

Closed CalumJEadie closed 11 years ago

CalumJEadie commented 11 years ago

Following on from the email I sent you earlier today I've integrated omxplayer into yt through the --player parameter.

Users using mplayer would experience no change as --player is optional however those wanting to use yt on the Raspberry Pi can use --player omxplayer to take advantage of the performance of omxplayer on the Pi.

rjw57 commented 11 years ago

Nice work. Could you merge the README.rst changes (ced74cb, d1de570, 9e87aed, 47c7143, 671d171 and d43640e) into one and I'll pull.

Also I'd suggest auto-configuring omxplayer/mplayer based on which is on the PATH preferring omxplayer if both are present letting the command-line option provide an override. (I.e. it should Do The Right Thing in most cases.) But that's a feature for after this pull request is merged.

CalumJEadie commented 11 years ago

No problem at all, I've squashed the README changes together.

That's a good shout. At the moment it's not very user friendly in that it expects the user to use --help or have read the documentation and be aware of the --program flag.

rjw57 commented 11 years ago

Merged. Thanks. I'll push a new version to pypi tomorrow.