rjwut / ArtClientLib

NOTE: This library is being superseded by IAN: https://github.com/rjwut/ian
14 stars 3 forks source link

Expose damaged systems on NPC ships #21

Closed IvanSanchez closed 10 years ago

IvanSanchez commented 10 years ago

I've been working on my own client library for Artemis, using the protocol documented here as a base. So far, it's been inmensely helpful.

When trying a few things with my library, I managed to decode a few more fields on the NpcUpdatePacket, previously undocumented, related to which systems have been damaged on a NPC vessel.

You might want to expose these fields properly.

rjwut commented 10 years ago

Thanks! I'll make sure to do this!

huin commented 10 years ago

Thanks, I've applied this to my own code as well! (and spotted/fixed a silly mistake while I was at it)

https://github.com/huin/artemis/commit/7518e6006a7a0f0173403c1434109e315c83ebab

huin commented 10 years ago

By the way, the order of the system types as discovered appears to be the same order (and number) of systems in the engineering console update packet (which works nicely for me, as I use the same shaped array and enumerated values in all cases, now).

rjwut commented 10 years ago

This was inadvertently committed at the same time as SHA: 90664e4162233dd3c9d1b046c0598f0d9e8f53c2. (I would have preferred to do it as a separate commit. Oh well.)