Upgrade to newer version of supertest

rjz / supertest-session

Persistent sessions for supertest

Other

89 stars 21 forks source link

Upgrade to newer version of supertest #24

Closed steebchen closed 7 years ago

steebchen commented 7 years ago

Upgrade to a newer version of supertest to fix double callback bug when using promises.

rjz commented 7 years ago

Thanks, @steebchen—looking forward to getting this merged up! For others' reference, could you link up the bug in question (or add a regression test to show the fix)?

steebchen commented 7 years ago

I don't have a code example since I used it in a big project, but upgrading to this version fixed the bug when returning multiple promises in chained .then()s. The warning which gets printed says "superagent: double callback bug. Upgrade to v3.2+ to fix this". I know that supertest^2 doesn't come with superagent^3.2, but the warning disappeared so I think that another code change fixed that. Not the best explanation, I know, but the upgrade did fix the warning for me.

rjz commented 7 years ago

Got it, and good to keep the dependencies updated in any case! Thanks again for taking care of this, @steebchen.

rjz commented 7 years ago

Published to npm as version 3.0.0.