search

rjz / supertest-session

Persistent sessions for supertest
Other
89 stars 21 forks source link

fix: add missing dependencies cookiejar and methods #46

Closed merceyz closed 4 years ago

merceyz commented 4 years ago

What's the problem this PR addresses?

supertest-session is using methods and cookiejar without declaring them as dependencies causing it to rely on something else in the dependency tree to declare it and that it's hoisted to an accesible location which is really fragile and prone to breaking. Under strict dependency systems like pnpm and Yarn PnP this does not work

Fixes https://github.com/rjz/supertest-session/issues/45

How did you fix it?

Added missing dependencies cookiejar and methods

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 95.833% when pulling 11b67c6b8ae29c8338f6acdd9befa5de1816bbcb on merceyz:missing-dependencies into 9358c35816c139b2bdd1e86d877f000fd62f69e1 on rjz:master.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 95.833% when pulling 11b67c6b8ae29c8338f6acdd9befa5de1816bbcb on merceyz:missing-dependencies into 9358c35816c139b2bdd1e86d877f000fd62f69e1 on rjz:master.

rjz commented 4 years ago

Thanks, @merceyz!