rkalis / truffle-assertions

🛠 Assertions and utilities for testing Ethereum smart contracts with Truffle unit tests
https://kalis.me/check-events-solidity-smart-contract-test-truffle/
MIT License
154 stars 20 forks source link

can not install with truffle-hdwallet-provider installed #28

Closed SvenMeyer closed 5 years ago

SvenMeyer commented 5 years ago

Describe the bug

install fails if truffle-hdwallet-provider is already installed

$ npm install truffle-hdwallet-provider@1.0.12
$ npm install npm install truffle-assertions

npm ERR! path /home/sum/DEV/test_HDWalletProvider_nonce/node_modules/web3-providers-ws/node_modules/websocket
npm ERR! code EISGIT
npm ERR! git /home/sum/DEV/test_HDWalletProvider_nonce/node_modules/web3-providers-ws/node_modules/websocket: Appears to be a git repo or submodule.
npm ERR! git     /home/sum/DEV/test_HDWalletProvider_nonce/node_modules/web3-providers-ws/node_modules/websocket
npm ERR! git Refusing to remove it. Update manually,
npm ERR! git or move it out of the way first.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/sum/.npm/_logs/2019-07-19T08_24_41_215Z-debug.log

Example test code

$ npm install truffle-hdwallet-provider@1.0.12
$ npm install npm install truffle-assertions

Expected behavior no error

Environment Information Truffle v5.0.27 (core: 5.0.27) Node v10.16.0 truffle-hdwallet-provider@1.0.12

2019-07-19T08_24_41_215Z-debug.log

rkalis commented 5 years ago

I see you closed the linked issue, does that mean this issue has been resolved?

SvenMeyer commented 5 years ago

When I tried to reproduced the problem once I had posted it as an issue nere on github, the error did not show up any more, so I closed the issue. When I later tried again, the error show up again, but I had no time to further investigate what might have caused it to show up again. Feel free to download the code and run it, should only take a minute ...

rkalis commented 5 years ago

I'm not able to reproduce this using your environment: Truffle v5.0.27 (core: 5.0.27) Node v10.16.0 truffle-hdwallet-provider@1.0.12

Is this still an issue for you that you're able to reproduce across multiple projects?

SvenMeyer commented 5 years ago

Looks ok to me now as well ...

rkalis commented 5 years ago

Strange, these kinds of bugs. Closing the issue for now, but let me know if it persists later.