rkarivuraj / coderev

Automatically exported from code.google.com/p/coderev
GNU General Public License v2.0
0 stars 0 forks source link

extra whitespace in filename when run under cygwin86 on windows xp for svn files #10

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install Cygwin with python and svn and patch and diff
2. run coderev on a svn repository

What is the expected output? What do you see instead?
The expected outcome is a code review generated
Instead the output is:
  *  path/file.pm | Not found
  *  path/file2.pm | Not found

What version of the product are you using? On what operating system?
coderev-0.3.3.tar.bz2   
windows xp and cygwin as of Nov 12, 2013

Please provide any additional information below.
The path passed to python appears to have a leading space that could be 
stripped.

I altered the pytohn to print out 
>            print self.__output
>            print f
>            print self.__obj1
>            print self.__obj2
>            target = os.path.join(self.__output, f)
>            obj1 = os.path.join(self.__obj1, f)
>            obj2 = os.path.join(self.__obj2, f)

And the output is: ( not leading space on 2nd line ' path/file.pm' )
/home/mdcarls/review
 path/file.pm
/tmp/coderev.rzAbxT/R14.01.0-base
.
  *  path/file.pm | Not found

In my own copy, I added the line ' f = f.strip()
>        for f in self.__file_list:
>            f = f.strip()
>            # set default values
>            from_lines = ''
>            to_lines = ''
>            from_date = ''
>            to_date = ''

And it works for my use cases.

Original issue reported on code.google.com by copl...@gmail.com on 12 Nov 2013 at 6:52

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
[Edited] Yes it is a bug, but I won't fix, sorry.  Instead, I suggest you do 
not use special chars in pathnames anymore, otherwise you will encounter more 
issues here and there sooner or later.

Original comment by matt...@gmail.com on 28 Nov 2013 at 9:57