Broken links for paths with spaces

[GoogleCodeExporter]

What steps will reproduce the problem?
1. run codediff.py on directories with subdirectories or files whose names 
contain spaces.

What is the expected output? What do you see instead?

Expect clickable links that work in index.html. Instead the links are 
broken.

What version of the product are you using? On what operating system?

coderev 0.3.3 on Mac OS X 10.6.

Please provide any additional information below.

I quick-fixed it with the attached patch by quoting the href attribute value, 
but a cleaner/more thorough solution would be to URL-escape the paths.

Original issue reported on code.google.com by liyanage on 4 Jan 2010 at 6:36

Attachments:

• codediff-a-href-quotes.patch

[GoogleCodeExporter]

Thanks for reporting this, fixed in r35 with your patch, works with most 
browsers so
I am not going to add URL escape right now but keep this open.

Original comment by matt...@gmail.com on 5 Jan 2010 at 2:52

[GoogleCodeExporter]

I just noticed that my first patch makes links work in Safari, but the links 
don't change 
color when visited. I now added the url escaping code in this new patch. It is 
against the 
result of my first patch.

Original comment by liyanage on 7 Jan 2010 at 1:56

Attachments:

• codediff-urlescape.patch

[GoogleCodeExporter]

Thanks for this fantastic tool btw. I use it in the following script to 
generate code review 
packages from within a Git working copy:

http://github.com/liyanage/macosx-shell-scripts/blob/master/git-coderev.sh

Original comment by liyanage on 7 Jan 2010 at 1:58

[GoogleCodeExporter]

Thanks, patch applied in r36.

Original comment by matt...@gmail.com on 7 Jan 2010 at 9:18

[GoogleCodeExporter]

Marking as fixed.

Original comment by matt...@gmail.com on 7 Jan 2010 at 9:19

• Changed state: Fixed

[GoogleCodeExporter]

Hi Marc,

Coderev.sh is designed to be capable to work with more Version Control System, 
to
work with a new VCS it needs to implements following operations

# VCS Operations: 
#   get_banner                        - print banner, return 1 if not supported
#   get_repository                    - print repository
#   get_project_path                  - print project path without repository
#   get_working_revision pathname ... - print working revision
#   get_active_list pathname ...      - print active file list
#   get_diff [diff_opt] pathname ...  - get diffs for active files
#   get_diff_opt 

User can benefit from coderev.sh when work under a local workspace - typical 
usage is
to generate html diffs based on local copy and changes for pre-commit code 
review.

I have no experience with git so do know whether this is doable.  If you are
interested to evaluate/implement, I would be very glad to help.

Matt

Original comment by matt...@gmail.com on 7 Jan 2010 at 9:35