rkashapov / i3lock-color-port

A port of i3lock-color for FreeBSD
1 stars 0 forks source link

Include in official FreeBSD ports tree #1

Open jwfh opened 4 years ago

jwfh commented 4 years ago

I use i3lock-color myself and was going to open a PR to the FreeBSD ports tree with PandorasFox's fork, but then noticed that since I last looked at that repo there is a link to this repo under the heading FreeBSD port in the README.

Before I opened the PR I just wanted to touch base with you via this issue to see if there is any advice you want to offer that you found when working on your version of the port, or any other comments you may have.

It looks like your Makefile is based on the logic in that of i3lock?

jwfh commented 4 years ago

My port is here.

rkashapov commented 4 years ago

Hi @jwfh ,

Before I opened the PR I just wanted to touch base with you via this issue to see if there is any advice you want to offer that you found when working on your version of the port, or any other comments you may have.

I don't have any advice.

When I tried to build i3lock-color from source code I faced some issues. I don't really remember, but I think they were related to dependencies. To make that process easier I've created my port and made a PR to i3lock-color to add a link to the port.

Unfortunately, I don't have enough time to maintain it. For this reason, I didn't try to merge it into the FreeBSD ports tree.

It'll be great if you also submit a PR to i3lock-color to update a FreeBSD port link.

It looks like your Makefile is based on the logic in that of i3lock?

Right, I just replaced links to the files being downloaded and renamed the package.

Thanks